RedReign / FoundryVTT-BetterRolls5e

A module for modifying certain sheet functions on Foundry VTT Character sheets for D&D 5th Edition.
GNU General Public License v3.0
36 stars 67 forks source link

Feature request: Add active effect name as context for rolls #263

Open jflevesque opened 3 years ago

jflevesque commented 3 years ago

Hi,

Not sure if this is something that core should offer or Better Rolls (or even if its possible), but it would be great if you could add as context the active effect's name to the rolls/die terms. For example, a Paladin with Improved Divine Smite has an extra 1d8 radiant added to all melee attack rolls. Currently, you only see it as extra die term, no information from where it comes from.

Here is an example of the current result: image And the active effect configured on the character: image

CarlosFdez commented 3 years ago

Unfortunately not that easy, and the new async roll feature coming to Foundry 0.8 is going to make that even harder. For now though, you could do 1d8[Improved Divine Smite] and you'll get some context as part of the roll syntax.

Core is implementing a new way to split damage for damage rows which I'm likely going to look into, so if core doesn't implement it then nothing really I can do.

jflevesque commented 3 years ago

You mean do 1d8[Improved Divine Smite] inside the weapon or in the active effect? If in the active effect, my testing indicated that the parsing failed or something, because the 1d8 was not added to the chat messages :(

CarlosFdez commented 3 years ago

I'll keep an eye on this for 0.8 soon, but unfortunately not very hopeful about it, active effect based stuff and making rolls identifiable can be quite clunky. In BR they tried to make parts of a roll easier to figure out but unfortunately there's only a certain length we're able to fight against the system.