search

RedReign / FoundryVTT-BetterRolls5e

A module for modifying certain sheet functions on Foundry VTT Character sheets for D&D 5th Edition.
GNU General Public License v3.0
37 stars 67 forks source link

Blind rolls not working #279

Closed Tapperton closed 3 years ago

Tapperton commented 3 years ago

image Blind GM rolls don't seem to hide properly when rolled as skill checks. Rolling regular dice seems to work, but not posting the rolls directly from the character sheet.

CarlosFdez commented 3 years ago

Can you give some more information on how this is happening? Are you viewing as the player or viewing as the GM? Rolling as the player or rolling as the GM? The background is purple which is the correct color for blind GM rolls. What was the first roll you're having?

Also test without plutonium. :^)

crash1115 commented 3 years ago

Rolling as a player: Private GM Rolls, Self Rolls, Blind rolls are all visible to me, all other players, and the GM. The card styling is right (the muted purple and blue where appropriate) and the "Name privately rolled some dice" appears at the top of the cards as expected.

Rolling as a GM: Same behavior.

image The other mod that is active is libwarapper.

CarlosFdez commented 3 years ago

Seems its a Foundry issue: https://gitlab.com/foundrynet/foundryvtt/-/issues/5302

Going to see how its resolved, but if they don't resolve it we'll have to do some hackery and the thought scares me.

ComedianTF2 commented 3 years ago

Looks like the 0.8.7 update fixes this issue, where it no longer shows the results

Dice System Whispered rolls have been returned to the workflow of always displaying that they were "rolled privately" for any User that does not have permission to view the content of the roll-type Chat Message.

image

CarlosFdez commented 3 years ago

Yup! Confirmed it was the case as well. Thank you for the reminder.