Fix Itemmacro call from hotbar

RedReign / FoundryVTT-BetterRolls5e

A module for modifying certain sheet functions on Foundry VTT Character sheets for D&D 5th Edition.

GNU General Public License v3.0

37 stars 67 forks source link

Fix Itemmacro call from hotbar #300

Closed mech-tools closed 3 years ago

mech-tools commented 3 years ago

Hi,

Trying to fix itemmacro not working from the hotbar. Tried quite a few things, but always get into a loop.

The only way I found was to update the macro template. Even tho it's not ideal, I didn't find any other solution. Because the default BR macro calls directly the overwritten roll function. And there is no way around that, expect serious refactoring.

Maybe you have a better idea?

This PR has no impact on existing BR installation or if ItemMacro is not installed/activated.

CarlosFdez commented 3 years ago

I am actually concerned as to why item.roll() doesn't work with item macro. It should use the regular libwrapper pipeline, but it seems like it does not. How unfortunate. Merging it in, thanks for this.

I was hoping to eventually see if I couldn't alternatively contribute to 5e to make their macros more robust once my work on pf2e calmed down (5e's hotbar macros requires tokens to be selected, for players it should default to their main owned token) and not have to implement our own hotbar solution, but it seems we have to go the opposite direction of that :(