search

RedReign / FoundryVTT-BetterRolls5e

A module for modifying certain sheet functions on Foundry VTT Character sheets for D&D 5th Edition.
GNU General Public License v3.0
36 stars 67 forks source link

Uncaught TypeError on Skill Roll #305

Open kiligir opened 3 years ago

kiligir commented 3 years ago

The error cropped up when I was trying to roll some downtime activities with Ethck's Downtime Tracking mod (which has a compatibility option for this one.) However, the following is getting flagged each time I just roll a skill from a sheet. Or any other roll, actually. It's preventing Ethck's mod from working, I think. You'd know more, obviously.


Uncaught (in promise) TypeError: result is undefined
    doRollSkill patching.js:95
    call_wrapper libWrapper-wrapper.js:574
    rollSkill#0 libWrapper-wrapper.js:162
    _onRollSkillCheck base.js:970
    jQuery 2
patching.js:95:3```
CarlosFdez commented 3 years ago

Thanks for reporting. There's def some problems in the implementation of the new override methods that I didn't catch in my scramble to finish implementation quickly. I'll make those functions more robust asap.

CarlosFdez commented 3 years ago

Try now, v1.6.1.

kiligir commented 3 years ago

Fixed the problem I was having, but now dual rolls doesn't seem to work...

CarlosFdez commented 3 years ago

Dunno how I didn't see this comment. Is it still having issues on the latest release?