RedReign / FoundryVTT-BetterRolls5e

A module for modifying certain sheet functions on Foundry VTT Character sheets for D&D 5th Edition.
GNU General Public License v3.0
36 stars 67 forks source link

Animation problem with JB2A+Automated Animation #310

Open Himuraken opened 3 years ago

Himuraken commented 3 years ago

Hello there,

I Found that some AOE JB2A effect don't trigger like, Entangle or Shockwave when i use Betters roll !

I'm using all lastest version and French language.

CarlosFdez commented 3 years ago

Are there any free AOE JB2A effects I can test with? I think the free selection might be weapons only.

Himuraken commented 3 years ago

Here you go 👍

https://www.reddit.com/r/FoundryVTT/comments/jj4igq/jb2a_free_animated_assets/

There is Entangle and a lot of AOE animation on the free module

There is a more official link : https://foundryvtt.com/packages/JB2A_DnD5e

CarlosFdez commented 3 years ago

Entangle is free? Then I'll look into it once I have some time (busy for at least a week). Though I'd appreciate it if someone looks into it and makes an MR during this time.

My suspicion is that we'll need to detect if the roll has an attack roll, if it does not, put "damage" in the flags instead of "attack". Or whatever save spells normally put in the chat without better rolls.

Himuraken commented 3 years ago

Me and my friends did a few other tests.

It looks like all the area spells (with template) don't trigger animation because they don't trigger an attack dice roll.

On the other hand, on Automated Animation, the option "Trigger animation on damage" makes things worse: No more animations work when this option is activated.

Himuraken commented 3 years ago

I create a new DND5e campaign, with the following modules:

JB2A Automated Animation Sequencer (dependency)

I created a scene on which I use two heroes Starter SRD.

I) Test without Better rolls

The attacks with target work and trigger an animation. (Mace, Crossbow, Fire, Healing ...) : everything is good.:ok_hand:

I import an AOE spell from the SRD compendium (Entangle) I configure the animation ( Edit spell, A-A, Model, square, Entangle) I use the spell, it triggers an animation; all is good. :ok_hand:

I) Test with Better rolls

I activate Better rolls and Libwrapper. (Dependency)

The attacks with target work and trigger an animation. (Mace, Crossbow, Fire, Healing ...) : everything is good. :ok_hand:

I import an AOE spell from the SRD compendium ( Entangle) I configure the animation ( Edit spell, A-A, Model, square, entangle) I use the spell, it triggers an animation; all is well.:ok_hand:

I import another AOE spell from the SRD compendium ( Wall of fire) I set up the animation (Edit Spell, A-A, Template, Custom Animation, Wall of Flame.) I use the spell, it triggers an animation; all is well. :ok_hand:

I tested by adding and removing all the modules one by one and here is what i found :

AOE are working with either Dice so Nice or Better rolls, but not both at the same time: if both are active at the same time, AOE does not work

Himuraken commented 3 years ago

So, I continued to test one by one the different module combinations with Better rolls and here is what it gives :

Better rolls + JB2A= :white_check_mark: MIDI QOL + Better rolls + JB2A = Don't trigger AOE animation:warning: DICE SO NICE + Better rolls + JB2A = Don't trigger AOE animation:warning: Midi QOL + DICE SO NICE + JB2A = :white_check_mark:

CarlosFdez commented 3 years ago

I am having trouble setting up entangle to work even without better rolls. Can you show me your A-A settings? I could start messing around with random settings but it wouldn't help debugging it at all unless I'm doing what you're doing.

You described what you did but the problem is that I'm not familiar with A-A. I have all the assets right now, I enabled automated animations, j2ba, and token magic, but it doesn't seem to work out of the box

mooseable commented 2 years ago

I logged an issue on Automated Animations, but it appears that because damage is autorolled when there is no attack roll, it does not trigger the animation to start. Magic Missile is a classic example.