Proficiency bonus is not added correctly for tools in the upcoming 1.5.x release of the 5e system

[Pjb518]

Hey,

I just wanted to give you a heads up about an issue in the upcoming 5e release.

A recent merge request added support for proficiency dice, and now tools checks don't work correctly in Better Rolls. No matter what the actor's proficiency level is with the tool, their proficiency bonus is never added.

In the new system, the proficiency bonus that actually gets applied to a roll is now a new piece of derived data, and Better Rolls seems to be deleting that property (prof) whenever a roll is made. This deletion seems to occur before the roll data is collected, causing this check to fail in the rollToolCheck method:

// Add proficiency
if ( this.data.data.prof?.hasProficiency ) {
  parts.push("@prof");
  rollData.prof = this.data.data.prof.term;
}

I don't know what exactly is causing the issue, but the property is there before making the roll, and it's not there after, and this only happens while Better Rolls is active.

Hope this helps!

[CarlosFdez]

Thanks for the headsup. Inconvenient timing but I guess we can't control these things.

[mbh9700]

I am noticing this problem as well. For now, just adding a manual numerical bonus to the tool.

[Ikabodo]

Yeah, just noticed this as well. Might be worth checking up now that 1.5 is released.