Issue: When importing an actor with attacks from the SRD or other external sources, or adding an attacking weapon to an existing character's sheet, the attack will not roll when clicked. This can be fixed manually by updating the attack (going into edit the item and then immediately closing the window to force an update), but it must be done on every single imported attack or weapon; I have not yet found an easier fix (reloading the module nor reloading the game does not fix this issue, and the attack will still fail to roll unless updated). Skill checks and other abilities still work on imported actors.
How to duplicate:
Create new game in Foundry v0.8.9, with Better Rolls (and dependencies) loaded.
Import monster from SRD or other sources, OR create new actor and give it a weapon from compendium.
Clicking on the roll icon next to newly imported monster's attack/actor's weapon fails to roll (and throws up error in console shown below).
Manually updating the particular attack by clicking edit item and then closing the window refreshes the actor's item and the roll will now work for that particular item on that actor. If actor has multiple attacks or multiple items are imported, each one must be updated manually for them to work.
Error log:
Uncaught (in promise) TypeError: Cannot read property 'threshold' of null
[Detected 1 package: betterrolls5e]
at Function.getCritThreshold (utils.js:423)
at Function.constructAttackRoll (fields.js:144)
at Function.constructModelsFromField (fields.js:437)
at CustomItemRoll._processField (custom-roll.js:975)
at async CustomItemRoll.roll (custom-roll.js:700)
at async CustomItemRoll.toMessage (custom-roll.js:823)
Loaded: Better Rolls v1.6.13 libWrapper v1.10.7.0 Foundry VTT v0.8.9 DnD5e v1.5.2
Issue: When importing an actor with attacks from the SRD or other external sources, or adding an attacking weapon to an existing character's sheet, the attack will not roll when clicked. This can be fixed manually by updating the attack (going into edit the item and then immediately closing the window to force an update), but it must be done on every single imported attack or weapon; I have not yet found an easier fix (reloading the module nor reloading the game does not fix this issue, and the attack will still fail to roll unless updated). Skill checks and other abilities still work on imported actors.
How to duplicate:
Error log: Uncaught (in promise) TypeError: Cannot read property 'threshold' of null [Detected 1 package: betterrolls5e] at Function.getCritThreshold (utils.js:423) at Function.constructAttackRoll (fields.js:144) at Function.constructModelsFromField (fields.js:437) at CustomItemRoll._processField (custom-roll.js:975) at async CustomItemRoll.roll (custom-roll.js:700) at async CustomItemRoll.toMessage (custom-roll.js:823)