RedReign / FoundryVTT-BetterRolls5e

A module for modifying certain sheet functions on Foundry VTT Character sheets for D&D 5th Edition.
GNU General Public License v3.0
37 stars 67 forks source link

When Dual Rolls are selected and the Dice So Nice module is activated, the dice cards don't show up #333

Closed jegasus closed 3 years ago

jegasus commented 3 years ago

I'm not sure if this issue is with Better Rolls for 5e or with Dice So Nice, so I'll post it on both GitHubs.

When I try to use the Dual Rolls option in Better Rolls for 5e when the Dice So Nice module is activated, the dice result cards never show up in the chat.

I only have three modules active in the world I'm testing this in:

This error shows up in the console:

TypeError: Cannot set properties of undefined (setting 'secret')
[Detected 3 packages: dice-so-nice, lib-wrapper, betterrolls5e]
    at Dice3D.showForRoll (Dice3D.js:477)
    at recursShowForRoll (main.js:275)
    at main.js:284
    at Function._call (eval at <anonymous> (listeners.js:92), <anonymous>:4:14)
    at Function.callAll (foundry.js:153)
    at ClientDatabaseBackend.callback (foundry.js:8777)
    at foundry.js:8716
    at Array.map (<anonymous>)
    at ClientDatabaseBackend._handleCreateDocuments (foundry.js:8716)
    at ClientDatabaseBackend._createDocuments (foundry.js:8612)
    at async Function.createDocuments (document.mjs:332)
    at async Function.create (document.mjs:431)
    at async CustomItemRoll.toMessage (custom-roll.js:850)
_call @ VM18606:7
callAll @ foundry.js:153
callback @ foundry.js:8777
(anonymous) @ foundry.js:8716
_handleCreateDocuments @ foundry.js:8716
_createDocuments @ foundry.js:8612
async function (async)
_createDocuments @ foundry.js:8603
create @ backend.mjs:96
async function (async)
create @ backend.mjs:93
createDocuments @ document.mjs:332
create @ document.mjs:431
toMessage @ custom-roll.js:850
async function (async)
toMessage @ custom-roll.js:823
itemRoll @ index.js:63
🎁call_wrapper @ libWrapper-wrapper.js:576
🎁CONFIG.Item.documentClass.prototype.roll#0 @ libWrapper-wrapper.js:164
_onItemRoll @ base.js:908
(anonymous) @ base.js:618
dispatch @ jquery.min.js:2
v.handle @ jquery.min.js:2

I'm currently running the following versions:

jegasus commented 3 years ago

Sorry! Had not seen that this issue was already reported in #331. Closing this now.