search

RedReign / FoundryVTT-BetterRolls5e

A module for modifying certain sheet functions on Foundry VTT Character sheets for D&D 5th Edition.
GNU General Public License v3.0
36 stars 67 forks source link

Critical damage calculation for secondary damage formula is incorrect #360

Closed RalphTheBard closed 2 years ago

RalphTheBard commented 2 years ago

Hey there. I'm currently on Foundry v0.8.9 and using Better Rolls v1.7.1. I've noticed that the Player view of the critical damage dice roll does not match what the DM sees, when secondary damage formulas are involved. Apparently, the player is only seeing the first damage formula's crit repeated for the second damage formula. See the attached pic for reference.

better_rolls_bug
hafdon commented 2 years ago

I'm having (i think the same) issue where if you click the "+" (crit) button on damage, and have Max Base Damage, Roll Critical Damage" selected in settings, it rolls the crit damage rather than maximizing any dice in that roll. I've included monster screenshots, I've tried this with the world system settings set at both Critical Damage Maximize dice true and false.

foundry 9.242 better rolls 1.7.1 dnd 1.5.7 chrome, windows 10

This also is a subissue for https://github.com/RedReign/FoundryVTT-BetterRolls5e/issues/338

image

image

RalphTheBard commented 2 years ago

Cannot repro in release 1.7.2. Closing. image