search

RedReign / FoundryVTT-BetterRolls5e

A module for modifying certain sheet functions on Foundry VTT Character sheets for D&D 5th Edition.
GNU General Public License v3.0
36 stars 67 forks source link

Various v9 bug fixes #365

Closed cs96and closed 2 years ago

cs96and commented 2 years ago

I appreciate you have stopped development on Better Rolls, but if you could see it in your heart to package a new release with these bug fixes... :smile:

CarlosFdez commented 2 years ago

Regarding the update to flags, I recall I did that because of this: https://github.com/RedReign/FoundryVTT-BetterRolls5e/commit/84c3e91a78b1d184820f308344c9868ae655677a

is this no longer an issue?

CarlosFdez commented 2 years ago

Also for clarification, PRs are still open, I'm just not developing for BR.

cs96and commented 2 years ago

Regarding the update to flags, I recall I did that because of this: 84c3e91

is this no longer an issue?

Hmmm, I don't know to be honest. How would I test it? What was the problem that your commit fixed?

CarlosFdez commented 2 years ago

If I remember correctly, its that proficiency bonuses weren't working for tool checks.

cs96and commented 2 years ago

Yes, you were correct, calling item.data.update() does cause tool rolls to lose their proficiency bonus for some reason. I'm not sure if this may be a bug in core foundry, or the dnd5e system.

Anyway, I've fixed that issue a different way, by calling ensureFlags() in addButtonsToItemLi() instead.

I also took the liberty to move the "expanded" check to the top of that function.

CarlosFdez commented 2 years ago

Looks good! And yeah I suspect this is a 5e bug involving data prep.