RedReign / FoundryVTT-BetterRolls5e

A module for modifying certain sheet functions on Foundry VTT Character sheets for D&D 5th Edition.
GNU General Public License v3.0
36 stars 67 forks source link

Bugfix for ammo bug (issue #377) #378

Open Zakkon opened 2 years ago

Zakkon commented 2 years ago

It seems the Dnd5e system (version 1.6.0) broke the BetterRolls5e v1.7.2 ability for weapons to draw ammo when it has an ammo source set. Instead it throws an error. The issue is, BetterRolls5e assumes an object called 'ammoUpdate' to contain the ammo source data it needs. As of Dnd5e v1.6.0, it appears 'ammoUpdate' now is an array containing the actual data BetterRolls5e needs.

cs96and commented 2 years ago

I've submitted a separate pull request (#382) which I think is slightly more correct than this one, as it correctly calls updateEmbeddedDocuments with the array.