search

RedReign / FoundryVTT-BetterRolls5e

A module for modifying certain sheet functions on Foundry VTT Character sheets for D&D 5th Edition.
GNU General Public License v3.0
36 stars 67 forks source link

Issue with Resource Consumption for Item Uses (such as Ki for monks) #380

Open GoldGeo opened 2 years ago

GoldGeo commented 2 years ago

When resource consumption is set to "Item Uses" and you attempt to reduce a resource of another feature (such as a monk using stunning strike to absorb Ki), the ability is used and the message is sent to chat, but no resources are consumed.

This seems linked to Issue 377 around ammunition consumption, however the pull request related to that issue did not fix this problem. image

Oshcakes commented 2 years ago

Seeing this as well.

Nedrapter commented 2 years ago

I'm experiencing this too. Setting Turn Undead to use Channel Divinity usages, but it does not. Deactivating the module fixes the issue.

Bekradan commented 2 years ago

Same issue here. Hopefully a fix will come soon.

Oshcakes commented 2 years ago

I think it may be time to move on to another module such as midi-qol - Looks like the dev is no longer supporting this module. https://github.com/RedReign/FoundryVTT-BetterRolls5e/issues/355#issuecomment-1003217900

DivertedCircle commented 2 years ago

I'm not getting this same issue, resources are being consumed fine for me. Make sure the 'Resource' checkbox is set to be consumed on the item in question. image

cs96and commented 2 years ago

I've submitted a pull request that fixes this issue and #377.

gris-x commented 2 years ago

Hi, the resource consumption for ammunition does not work when Better Roll module is on. It works fine when the module is turned off. (I see posts about a fix, but I am not sure it works as I keep all my modules updated through Forge and it still does not work)

Nedrapter commented 2 years ago

I don't think it's fixed. Still broken for me as well with everything updated.

cs96and commented 2 years ago

I submitted a pull request, but it has not been accepted and officially released. You will have to apply my patch to your Foundry server manually.