RedReign / FoundryVTT-BetterRolls5e

A module for modifying certain sheet functions on Foundry VTT Character sheets for D&D 5th Edition.
GNU General Public License v3.0
36 stars 67 forks source link

Compatibility issue with Argon HUD #384

Open varXX404 opened 2 years ago

varXX404 commented 2 years ago
Uncaught (in promise) Error: You must provide an _id for every object in the update data Array.
[Detected 4 packages: betterrolls5e, lib-wrapper, midi-qol, enhancedcombathud]
    _preUpdateDocumentArray https://foundry.mydomain.com/scripts/foundry.js:10185
    _updateEmbeddedDocuments https://foundry.mydomain.com/scripts/foundry.js:10152
    update https://foundry.mydomain.com/common/abstract/backend.mjs:153

This error seems to occur when Argon Combat HUD, Midi QOL, and BetterRolls are active together. Effectively it seems that Better Rolls blocks the messages from Argon when clicking one of the special action buttons (such as dodge, ready, dash, etc.), which prevents Midi from applying these conditions as DFreds Convenient Effects.

theripper stated that this was an issue on this side and outside his power, and asked for it to be added as an issue here https://github.com/theripper93/enhancedcombathud/issues/100

Please, a fix for this would be really nice.

Larkinabout commented 2 years ago

Hi @varXX404, if you still need it, I've put up a release with this issue fixed over at my fork, including @cs96and's ammo fix.

varXX404 commented 2 years ago

@Larkinabout awesome, thank you ! Any chance you can get in contact wiht @RedReign to officially take over the module if you are maintaining it ? Would love for more people to have access to the most up-to-date version of the module.

Larkinabout commented 2 years ago

I'm not sure what's happening with this at the moment. Last I spoke to @CarlosFdez earlier this month, LukeAbby was working on a v10 version, but not maintaining the current version here yet. I'm sort of waiting for v10 as any effort I put into understanding and maintaining this version would probably overstep what's happening there and become redundant too.

Aside from that, I'm still actively using Better Rolls 5e myself, so would be keen to help out where I can.

Elthair commented 1 year ago

Hi @varXX404, if you still need it, I've put up a release with this issue fixed over at my fork, including @cs96and's ammo fix.

thnaks but how to install this fork?

cs96and commented 1 year ago

Note that BetterRolls is no longer being developed. Unless you are still on v9 of foundry, you should switch to Ready Set Roll

varXX404 commented 1 year ago

Hi @varXX404, if you still need it, I've put up a release with this issue fixed over at my fork, including @cs96and's ammo fix.

thnaks but how to install this fork?

As cs96 said, you should be switching over to Ready Set Roll for anything past V9, as for installing it, I think you can just download it as a zip, go to the modules folder of your install and just overwrite the betterrolls folder with the one from the fork download