8 write test for genericsdk

RedSkiesIO / cryptowallet-js

A BIP-44 multi crypto currency llibrary

https://www.atlascity.io

GNU General Public License v2.0

3 stars 4 forks source link

Closed stxphxn closed 5 years ago

stxphxn commented 5 years ago

This pull request is to migrate the unit tests for genricSDK into the develop branch.

nshCore commented 5 years ago

Here is an overview of what got changed by this pull request:


Clones removed
==============
+ lib/SDKS/GenericSDK.js  -21
+ lib/SDKS/bitcoin/index.js  -12
+ lib/SDKS/ethereum/index.js  -6

See the complete overview on Codacy

nshCore commented 5 years ago

Test's where failing due to missing chai dependancy used for assertions, as well as empty test files.

Have fixed these now and will merge