search

RedSpah / xxhash_cpp

Port of the xxhash library to C++17.
BSD 2-Clause "Simplified" License
165 stars 35 forks source link

from_canonical function is missing #31

Closed bitbugprime closed 1 year ago

bitbugprime commented 1 year ago

Comments for issue #17 say that from_canonical() was added, but after extracting the 0.8.1 tarball fgrep cannot find any such function.

RedSpah commented 1 year ago

I miswrote there, my bad, that's what I get for writing up comments at 2 AM. Upon comparing the C and CPP version of the library, I realized that the currently existing canonical_t::to_hash() function does what the theoretical from_canonical() function would, and so the latter would be superfluous.

bitbugprime commented 1 year ago

Did you mean get_hash() not to_hash()?

RedSpah commented 1 year ago

Yes, my bad.