search

RedSparr0w / Pokeclicker-desktop

46 stars 18 forks source link

Use discord-rich-presence instead of discord-rpc #2

Closed kittenchilly closed 2 years ago

kittenchilly commented 2 years ago

Basically a wrapper for the latter, makes things easier to develop. Also updated all dependencies and all assets to the latest pokeclicker version.

RedSparr0w commented 2 years ago

I don't really see the point in swapping to discord-rich-presence, it doesn't really make anything easier/better and is just another dependency,

kittenchilly commented 2 years ago

discord-rich-presence replaces discord-rpc as a dependency, it isn't something added on alongside it

RedSparr0w commented 2 years ago

It doesn't replace it as it's just a wrapper for it.

As it depends on discord-rpc this means discord-rpc is still a dependency in the project and will also lag behind on any updates discord-rpc has as discord-rich-presence would need to be updated after.

kittenchilly commented 2 years ago

When looking around, I've noticed a lot of electron apps use discord-rich-presence over discord-rpc. It does actually simplify the code, and it'd be easier to develop for whenever we want to do more with our rich presence support

RedSparr0w commented 2 years ago

IMO it doesn't really simplify or make anything easier in terms of development and I would rather not change over to using it, If you could revert that, everything else in the PR looks fine to me.