search

RedSquirrel87 / manga-downloader

A very simple application written in JAVA to download any chapters of any manga from the supported websites
35 stars 1 forks source link

Unable to create the output single file #728

Open RedSquirrel87 opened 1 year ago

RedSquirrel87 commented 1 year ago

Original report by nexist (Bitbucket: nexist, GitHub: nexist).

All other manga have successfully been downloaded into CBZ files. Today, one file is giving me an error. The log says:

00:45:08:  Getting pages list for chapter Ch. 34: Races’ Desires...
00:45:08:  30 pages found for this chapter.
00:45:08:  Downloading pages...
00:45:08:  Unable to create the output single file.

Manga is on Mangadex: Lv2 kara Cheat datta Moto Yuusha Kouho no Mattari Isekai Life
https://mangadex.org/title/58bc83a0-1808-484e-88b9-17e167469e23/lv2-kara-cheat-datta-moto-yuusha-kouho-no-mattari-isekai-life

Chapter is: Ch. 34 - Races’ Desires

Note, I can view the chapter on Mangadex. Also, the folder for the file/series exists and there is plenty of disk space.

OS is Windows 11.

Manga Downloader is v58.1

Createed Subfolder Limit Length 50 char
Created Manga Chapter Filename: Manga Name added to original title

If I was to guess, I would think it was the weird apostrophe, but I just pasted it into a text document rename field within the file explorer without an error.

RedSquirrel87 commented 1 year ago

Original comment by Red Squirrel (Bitbucket: Red_Squirrel, GitHub: RedSquirrel87).

Thank you for reporting the issue, there is a bug that for some reason adds a space at the end of the folder’s name and so the program can not find it (because the folder does not have it). I’ll search for the cause and I’ll release a fix in upcoming days 👍

RedSquirrel87 commented 1 year ago

Original comment by Red Squirrel (Bitbucket: Red_Squirrel, GitHub: RedSquirrel87).

Ok I found the cause, simply the manga name is over 50 chars (the default value) so it got cutted indeed on the space before Isekai (so “Lv2 kara Cheat datta Moto Yuusha Kouho no Mattari “) and the final space gives issues. To overcome the problem in the meanwhile you can increase the Manga name max length from the program settings for filename and restart it:

‌

In next version I’ll insert a check to remove any final space to avoid this issue in future

RedSquirrel87 commented 1 year ago

Original comment by nexist (Bitbucket: nexist, GitHub: nexist).

I have a fair number of manga (I don’t see a count anywhere on the bookmark view) so I am afraid that adjusting the length will not only create new directories for everything, but will also choke on another title that just happens to have a space at the 51 char mark... I’ll just manually download the offending chapter for now – & look forward to the next release.