search

RedSquirrel87 / manga-downloader

A very simple application written in JAVA to download any chapters of any manga from the supported websites
36 stars 1 forks source link

ReaperScans, issue getting chapter list for large series. #768

Closed RedSquirrel87 closed 1 year ago

RedSquirrel87 commented 1 year ago

Original report by Anonymous.

Application is returning an error when trying to get the chapter list for larger series, this one for example doesn’t work; https://reaperscans.com/comics/4921-demonic-emperor

Whereas this one dose; https://reaperscans.com/comics/4364-estio

RedSquirrel87 commented 1 year ago

Original comment by Red Squirrel (Bitbucket: Red_Squirrel, GitHub: RedSquirrel87).

Thank you for reporting the issue, I’ll try to fix this in next version

RedSquirrel87 commented 1 year ago

Original comment by Red Squirrel (Bitbucket: Red_Squirrel, GitHub: RedSquirrel87).

Oh I found where is the issue, after too much requests the website returns the 429 error, that's why the problem occurs only with manga with many pages of chapters to request. I'll fix it by putting a wait for a few seconds between requests, even if this way the program will take longer to get the complete list of chapters (especially with manga with many chapters) this should solve the issue. The fix will be available in tonight nightly build and of cource in next public release too 👍🏻

RedSquirrel87 commented 1 year ago

v60 released, it should fix this issue

Steven-OConnell commented 1 year ago

ReaperScans is still broken, the logs still show a 429 error.

[Wed May 10 15:02:19 CST 2023] Loading manga from https://reaperscans.com/comics/4921-demonic-emperor [Wed May 10 15:02:35 CST 2023] HTTP response code: 200 [Wed May 10 15:02:35 CST 2023] Framework: REAPERSCANS [Wed May 10 15:02:43 CST 2023] HTTP response code: 429 [Wed May 10 15:02:43 CST 2023] Error: NULL HTML code (-2). [Wed May 10 15:02:43 CST 2023] Error while getting chapters list: java.lang.NullPointerException: Cannot invoke "String.length()" because "s" is null at java.base/java.io.StringReader.<init>(StringReader.java:51) at com.google.gson.JsonParser.parseString(JsonParser.java:47) at mainpackage.ReaperScans.GetChapters(ReaperScans.java:150) at mainpackage.NewJFrame.GetChaptersList(NewJFrame.java:8941) at mainpackage.NewJFrame.access$22000(NewJFrame.java:164) at mainpackage.NewJFrame$201.run(NewJFrame.java:9316) at java.base/java.lang.Thread.run(Thread.java:833) [Wed May 10 15:02:43 CST 2023] Error: NULL chapters list.

I also tried this with a VPN to make sure my IP wasn't getting blocked either.

RedSquirrel87 commented 1 year ago

v60.1 just released, I increased the waiting time to a random value from 1 to 2 seconds. Please let me know if now it works for you too

Steven-OConnell commented 1 year ago

~~I just confirmed that it is working now. Thanks a lot for the fix. As a side note: Both HakuNeko & HDoujin Downloader have the same problem, so you're basically the only one who's got this working correctly ATM. XD~~

Edit: Nevermind, it seems that the chapter list is now populating correctly however all the images are returning a HTTP 403 error

jvm_log.txt

RedSquirrel87 commented 1 year ago

I just released a new update (v60.2) that should fix the 403 error, please let me know if it works now 👍🏻

Steven-OConnell commented 1 year ago

Alright awesome, it is working. I checked the downloaded content and it's all there. Thanks a lot. :)