RedTurtle / redturtle.volto

Helper package to setup a RedTurtle's Plone site ready to work with Volto
GNU General Public License v2.0
1 stars 1 forks source link

fix: fix-links behavior due to a problem with external links substitution #78

Closed luca-bellenghi closed 1 year ago

luca-bellenghi commented 1 year ago

Problem is that if we change testurl.it with correcturl.it on a link ct the subs it's always changing with a site relative domain.

eg. testurl.it/testA will be always changed with /${portal_url}/resolveuid/1234567890 with 1234567890 the UID of testA.

if correcturl.it it's a different site this behavior will brake the link

arsenico13 commented 1 year ago

I totally agree with this PR.

This change avoid the mentioned problem and let us use this utility-view for a lot a use cases (like the one in which we discovered this bug).

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 6481104628


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/redturtle/volto/browser/fix_links.py 1 8 12.5%
<!-- Total: 1 8 12.5% -->
Totals Coverage Status
Change from base Build 6469968137: -0.3%
Covered Lines: 766
Relevant Lines: 1227

💛 - Coveralls