search

Redd-Developer / howurls.work

Learn how URLs work by visually inspecting their structure.
https://howurls.work
MIT License
100 stars 9 forks source link

Subdomains #17

Open niklas-e opened 4 years ago

niklas-e commented 4 years ago

Resolves #1

Added section for subdomains. I tried to keep the description in line with others, but if you have any suggestions or ideas, I can make changes :slightly_smiling_face:

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/redd/howurls-work/jhhdizgk4 ✅ Preview: https://howurls-work-git-fork-niklas-e-subdomains.redd.now.sh

kettanaito commented 4 years ago

Hey, @niklas-e! Thank you so much for this contribution! I'll give it a closer look sometime next week. I think we should introduce a fallback to English in case there's no translation for strings. I can do this as a separate pull request that precedes this one.

niklas-e commented 4 years ago

Yeah, fallback would be great. Didn't actually notice there wasn't one already as I didn't check the localization implementation. I guess I'm too used to have react-i18next or something similar in my projects.

d-damien commented 3 years ago

Technically the dot isn't part of the subdomain. We need to tell domains, sub- and TLDs, are separated by dots. I think an additional panel is needed ; hopefully it won't be too hard to see & click on a dot.

I take that back. Following the spirit of previous panels, including the separator is intuitive enough.

niklas-e commented 11 months ago

I just noticed this is still open. Is there some prerequisites before this can be merged @kettanaito?

I think we should introduce a fallback to English in case there's no translation for strings. I can do this as a separate pull request that precedes this one.

Have you implemented this?

kettanaito commented 11 months ago

@niklas-e, no, I haven't got the chance to implement the language fallback. It should be rather straightforward to do. Right now, if the translation is missing, it will show the label IDs:

Screenshot 2023-12-11 at 19 03 56

This isn't nice. I can help translating the new section into as many languages I know but looks like we need some help from the community to provide other translations (such as Chinese, for example).

If you are final with the English description, I can post this pull request around and I'm sure people will help with translations!

kettanaito commented 11 months ago

I wonder if the dot following the subdomain is considered a part of the subdomain? 🤔 Right now, the way it's highlighted in the UI implies that is is.