search

Redgram / redgram-for-reddit

An Open-Sourced Android Reddit Client
GNU General Public License v3.0
102 stars 19 forks source link

Update RxAndroid/RxJava to latest #28

Closed bidluo closed 8 years ago

bidluo commented 8 years ago

As per issue #24. Works fine locally, though since we don't have any tests yet it's hard to tell if I broke anything.

mhdatie commented 8 years ago

When trying to make modules app it throws a missing Android Manifest error

Error:Android Source Generator: [Redgram] AndroidManifest.xml file not found

bidluo commented 8 years ago

Not sure what would cause that as the manifest is clearly there and making the app module works fine on my end. Perhaps try rebuild/clean? Chances are, it's because of the gradle update

mhdatie commented 8 years ago

Cleaning the project didn't work. I can switch between master and dev-settings with no problems but not to dev. For now I am reverting to HEAD -1 :

  1. git fetch origin dev
  2. git pull
  3. git reset --hard 096e2a7ce52c2539eddd541a9a1a696436bcc9e0

We need someone else to update their repository and confirm nothing went wrong with them

fbis251 commented 8 years ago

This pull request worked fine for me, I just built and installed the APK using commit 03025c2f05489afe04f14e9d9326d854bf231e69

mhdatie commented 8 years ago

Weird, I will spend more time on it then

ericfabreu commented 8 years ago

The app is building here too

mhdatie commented 8 years ago

I got it to work too. Thanks to @bidlou 's tip, I had to delete the idea folder and reopen the project.