search

Redgram / redgram-for-reddit

An Open-Sourced Android Reddit Client
GNU General Public License v3.0
102 stars 19 forks source link

Program to interfaces #3

Closed mhdatie closed 7 years ago

mhdatie commented 9 years ago

In the Todo list I have provided a link that explains what this term means. I was also told in a Reddit comment that I should not add static dependencies to the Application Class and should inject them through Dagger and "program to interfaces." This also applies to the whole application.

I'm currently reading about Dagger in order to apply it throughout the code. If you're familiar with it, and can provide a running example on this code, it would be appreciated.

Interfaces ease unit testing, and to depend on interfaces needs good design and good naming conventions for the code to be easy to read.

The current single network call could be extended to a search function later on, but for now, the goal is to build a reliable base which would explain how things should go on.

I am looking at ways to use RxJava for UI listeners, image and video display as shown in thisrepo: https://github.com/dlew/android-gfycat

Let me hear out your thoughts please. Thanks.

mhdatie commented 9 years ago

I also created a dev branch and would like to follow this branching model http://nvie.com/posts/a-successful-git-branching-model/

Thanks to @AdeebNqo. I will currently narrow it down to 2 branches: master and dev.