[2.2] Update coordination strategy of FlatSearchCommandHandler

RediSearch / RSCoordinator

RediSearch coordinator

Other

23 stars 10 forks source link

[2.2] Update coordination strategy of FlatSearchCommandHandler #331

Open Skoucail opened 2 years ago

Skoucail commented 2 years ago

Add MRCluster_MastersOnly to the coordination strategy of the FlatSearchCommandHandler This fixes #326

Skoucail commented 2 years ago

@rafie Can you help me? I have no clue why that 1 single test fails on the build server because of my PR

rafie commented 2 years ago

Hello @Skoucail, this is a flaky test, just needs a re-run. However, please note we no longer accept PRs on the RSCoordinator repo (as RSCoordinator is now integrated into the RediSearch repo). Instead, please open a PR on RediSearch/master, and modify files under the coord directory. Thanks!

Skoucail commented 2 years ago

@rafie Oh okee, didnt know this repo is depricated now. I did a test with the RediSearch 2.2 branch. Same issue. So i recreated the pull request over in RediSearch: https://github.com/RediSearch/RediSearch/pull/2404

CLAassistant commented 1 year ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}