search

RediSearch / RSCoordinator

RediSearch coordinator
Other
23 stars 10 forks source link

Ftl pkg #79

Closed mnunberg closed 5 years ago

MeirShpilraien commented 5 years ago

@mnunberg can you pls make a PR on RediSearch oss with all the changes you did there?

MeirShpilraien commented 5 years ago

IIUC the light build will be uploaded to the same directory as the enterprise os s3 (only with different name). @K-Jo is that ok?

MeirShpilraien commented 5 years ago

In addition @K-Jo, should we also bundle the rediseach light to enterprise?

mnunberg commented 5 years ago

@MeirShpilraien https://github.com/RediSearch/RediSearch/pull/962

MeirShpilraien commented 5 years ago

@mnunberg lets wait for @K-Jo to reply. Also make sure to point RediSearch sub-module to point to master after merge RediSearch/RediSearch#962 otherwise it might cause issues if we merge it and squash ..

K-Jo commented 5 years ago

IIUC the light build will be uploaded to the same directory as the enterprise os s3 (only with different name). @K-Jo is that ok?

correct there should be a RediSearch and a RediSearch-Light artefact (no longer one containing enterprise)

I did not add this to the doc, I apologise

K-Jo commented 5 years ago

In addition @K-Jo, should we also bundle the rediseach light to enterprise?

good question. for now NO. we don't want to confuse people and chose to default for the coordinator version. The SA's are aware of the existence

MeirShpilraien commented 5 years ago

IIUC the light build will be uploaded to the same directory as the enterprise os s3 (only with different name). @K-Jo is that ok?

correct there should be a RediSearch and a RediSearch-Light artefact (no longer one containing enterprise)

I did not add this to the doc, I apologise

But does it need to be in different directories or same directory?

K-Jo commented 5 years ago

IIUC the light build will be uploaded to the same directory as the enterprise os s3 (only with different name). @K-Jo is that ok?

correct there should be a RediSearch and a RediSearch-Light artefact (no longer one containing enterprise) I did not add this to the doc, I apologise

But does it need to be in different directories or same directory?

if there is no good reason to make 2 folders or 1, I don't have anything against either options. however, the artefact should be redisearch and redisearch-light in the name and not have enterprise in it, neither the folder

MeirShpilraien commented 5 years ago

IIUC the light build will be uploaded to the same directory as the enterprise os s3 (only with different name). @K-Jo is that ok?

correct there should be a RediSearch and a RediSearch-Light artefact (no longer one containing enterprise) I did not add this to the doc, I apologise

But does it need to be in different directories or same directory?

if there is no good reason to make 2 folders or 1, I don't have anything against either options. however, the artefact should be redisearch and redisearch-light in the name and not have enterprise in it, neither the folder

This is not good, automation depends on that, they search for redis-enterprise. If we change it they will need to search by version. It will cause problems...

mnunberg commented 5 years ago

@K-Jo @MeirShpilraien passes ci; should be good to go. need to verify with omri first