RediSearch / redisearch-go

Go client for RediSearch
https://redisearch.io
BSD 3-Clause "New" or "Revised" License
288 stars 65 forks source link

Support Vector Similarity #151

Closed Avital-Fine closed 2 years ago

Avital-Fine commented 2 years ago

closes #146

chayim commented 2 years ago

@Avital-Fine the code looks right, but did you notice the CI failure? I think it's because we're using redisearch:1.6.15 and you probably want a more modern docker (redis-stack-server or redismod)

Avital-Fine commented 2 years ago

@Avital-Fine the code looks right, but did you notice the CI failure? I think it's because we're using redisearch:1.6.15 and you probably want a more modern docker (redis-stack-server or redismod)

How do I update the docker then? I was trying to add tests with the client now and it is failing

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov[bot] commented 2 years ago

Codecov Report

Merging #151 (6cb299c) into master (5c6afe8) will increase coverage by 0.41%. The diff coverage is 91.89%.

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   76.44%   76.86%   +0.41%     
==========================================
  Files          13       13              
  Lines        1346     1383      +37     
==========================================
+ Hits         1029     1063      +34     
- Misses        259      261       +2     
- Partials       58       59       +1     
Impacted Files Coverage Δ
redisearch/schema.go 88.29% <85.00%> (-0.40%) :arrow_down:
redisearch/query.go 87.24% <100.00%> (+1.21%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c6afe8...6cb299c. Read the comment docs.