RediSearch / redisearch-go

Go client for RediSearch
https://redisearch.io
BSD 3-Clause "New" or "Revised" License
298 stars 66 forks source link

Added support for SLOP #97

Closed devinsburke closed 3 years ago

devinsburke commented 3 years ago

Added support for SLOP. Changed the int to an *int pointer (nullable) because SLOP 0 is a valid activity. The existing slop int attribute of the query struct was completely unused/unreferenced previously.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

codecov[bot] commented 3 years ago

Codecov Report

Merging #97 (d2e39e9) into master (f79df23) will decrease coverage by 0.13%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   76.77%   76.63%   -0.14%     
==========================================
  Files          13       13              
  Lines        1098     1100       +2     
==========================================
  Hits          843      843              
- Misses        198      199       +1     
- Partials       57       58       +1     
Impacted Files Coverage Δ
redisearch/query.go 85.71% <0.00%> (-1.19%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f79df23...d2e39e9. Read the comment docs.

filipecosta90 commented 3 years ago

@devinsburke can we add a test for it?

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

filipecosta90 commented 3 years ago

Merged @devinsburke . Thank you! I'll add some extra testing afterwards...