search

RedisBloom / redisbloom-py

Python client for Redisbloom
https://redisbloom.io
BSD 3-Clause "New" or "Revised" License
76 stars 11 forks source link

add T-Digest support #25

Closed AvitalFineRedis closed 3 years ago

AvitalFineRedis commented 3 years ago

fix #24

codecov[bot] commented 3 years ago

Codecov Report

Merging #25 (3626301) into master (849e48c) will increase coverage by 0.26%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage   98.39%   98.65%   +0.26%     
==========================================
  Files           2        2              
  Lines         435      522      +87     
==========================================
+ Hits          428      515      +87     
  Misses          7        7
Impacted Files Coverage Δ
redisbloom/client.py 98.43% <100.00%> (+0.31%) :arrow_up:
test_commands.py 99.01% <100.00%> (+0.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 849e48c...3626301. Read the comment docs.

filipecosta90 commented 3 years ago

@AvitalFineRedis With regards to the TDigest support it's flawless on the commands and test. great job! Got only one comment with regards the mixing of formatting and features: can we removed the line changes about formating?

PS: please check https://github.com/RedisBloom/redisbloom-py/issues/26 with regards a proposal of code formating ( that has always the same look and feel )

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication