search

RedisBloom / redisbloom-py

Python client for Redisbloom
https://redisbloom.io
BSD 3-Clause "New" or "Revised" License
76 stars 11 forks source link

Update for TopK.Add which returns expelled items #3

Closed ashtul closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #3 into master will decrease coverage by 0.29%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master       #3     +/-   ##
=========================================
- Coverage   98.79%   98.49%   -0.3%     
=========================================
  Files           2        2             
  Lines         331      333      +2     
=========================================
+ Hits          327      328      +1     
- Misses          4        5      +1
Impacted Files Coverage Δ
test_commands.py 100% <100%> (ø) :arrow_up:
redisbloom/client.py 97.47% <100%> (-0.49%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 231bc91...4f8ac00. Read the comment docs.

ashtul commented 5 years ago

If anything changes in the future. They can be eliminated. I debated it myself.

On 21 Jun 2019, at 12:08, Guy Korland notifications@github.com wrote:

@gkorland commented on this pull request.

In redisbloom/client.py:

@@ -101,34 +104,35 @@ def init(self, *args, **kwargs): self.BF_RESERVE : bool_ok,

self.BF_ADD : spaceHolder,

self.BF_MADD : spaceHolder,

  • self.BF_INSERT : spaceHolder,
  • self.BF_EXISTS : spaceHolder,
  • self.BF_MEXISTS : spaceHolder,
  • self.BF_SCANDUMP : spaceHolder,
  • self.BF_LOADCHUNK : spaceHolder,

  • self.BF_INSERT : spaceHolder,

  • self.BF_EXISTS : spaceHolder,

    @ashtul why do we keep the commented out lines?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.