search

RedisGraph / redisgraph-go

A Golang client for redisgraph
https://redisgraph.io
BSD 3-Clause "New" or "Revised" License
132 stars 38 forks source link

Add read only query support. #46

Closed mikewilson-dd closed 3 years ago

mikewilson-dd commented 3 years ago

Just quickly adding in support for the QUERY_RO command.

mikewilson-dd commented 3 years ago

@filipecosta90 Hey, sorry to ping you directly -- not sure how active this repo is, but I could really use this feature and it's pretty simple.

filipecosta90 commented 3 years ago

@filipecosta90 Hey, sorry to ping you directly -- not sure how active this repo is, but I could really use this feature and it's pretty simple.

Hi there @mikewilson-dd , thank you for submitting the PR and pushing it forward. LVGTM. Asking @swilly22 or @jeffreylovitz for an expert opinion on graph :)

filipecosta90 commented 3 years ago

@mikewilson-dd after discussing the naming with @swilly22 we've agreed that is best to keep the language standards and go with your suggestion of RoQuery, making the following func (g *Graph) ROQuery(q string) (*QueryResult, error) signature. I've reverted that specific change from the latest commit and we're good to go :+1: Thank you for pushing this forward!

mikewilson-dd commented 3 years ago

Thanks all!