RedisGraph / redisgraph-py

RedisGraph python client
https://redisgraph.io
BSD 3-Clause "New" or "Revised" License
189 stars 49 forks source link

Introduce tox, add more tests & fix bugs #114

Closed boris-42 closed 3 years ago

boris-42 commented 3 years ago

If this is accepted next steps are planned:

Note: check commit by commit for simplicity they are separated logical steps

boris-42 commented 3 years ago

@gkorland @swilly22 Okay guys before moving with refactoring I think it's good idea to cover everything with unittests, can you please take a look at this PR what do you think?

swilly22 commented 3 years ago

Hi @boris-42, we really appricate all of your help! I'll review this PR carefully tomorrow morning. thank you!

swilly22 commented 3 years ago

@boris-42 CI currently fails at:

run tests
0s
#!/bin/bash -eo pipefail
. venv/bin/activate
coverage run tests/functional/test_all.py
Traceback (most recent call last):
  File "tests/functional/test_all.py", line 2, in <module>
    from tests.utils import base
ModuleNotFoundError: No module named 'tests'

Exited with code exit status 1
CircleCI received exit code 1

Care to dig into this?

boris-42 commented 3 years ago

@swilly22 Will do it today