search

RedisGraph / redisgraph-py

RedisGraph python client
https://redisgraph.io
BSD 3-Clause "New" or "Revised" License
189 stars 49 forks source link

Switch circle CI to tox #115

Closed boris-42 closed 3 years ago

boris-42 commented 3 years ago

It makes sense to use the same technologies locally and in CI as it simplifies local debugging and verifing changes

Before this patch we did run sdist (bulding package) and functional tests in CI and we were uploading coverage report to covecod

After this PR we are adding code style jobs, unittests with coverage as well as keeping old jobs in place (but run through tox)

As well now we have 2 reports to upload one for functional tests one for unittests

boris-42 commented 3 years ago

@swilly22 here is the PR that should address circle ci issues, but for some reason circle Ci is not running on my PR

boris-42 commented 3 years ago

@swilly22 I saw some very old image configuration option. It seems like you'll need to enable it in CircleCI configuration. so circle CI is triggered on opened PR

boris-42 commented 3 years ago

@swilly22 CI is still not working, hm will prepare one more PR

swilly22 commented 3 years ago

@boris-42 still no go

#!/bin/bash -eo pipefail
pip install tox
Collecting tox
  Downloading https://files.pythonhosted.org/packages/e0/79/5915b9dad867e89bb6495456acfe5d4e2287e74dfa29c059f7b127d5480e/tox-3.20.1-py2.py3-none-any.whl (83kB)
    100% |████████████████████████████████| 92kB 3.6MB/s eta 0:00:01
Collecting virtualenv!=20.0.0,!=20.0.1,!=20.0.2,!=20.0.3,!=20.0.4,!=20.0.5,!=20.0.6,!=20.0.7,>=16.0.0 (from tox)
  Downloading https://files.pythonhosted.org/packages/1a/c6/bb564f5eec616d241e85d741f00a07f5f50ea12989022ad49bc66876993c/virtualenv-20.2.2-py2.py3-none-any.whl (5.7MB)
    100% |████████████████████████████████| 5.7MB 289kB/s eta 0:00:01
Collecting pluggy>=0.12.0 (from tox)
CircleCI received exit code 2

https://app.circleci.com/pipelines/github/RedisGraph/redisgraph-py/459/workflows/c2deb5ab-7f88-4805-81e9-e4e041cb154f/jobs/821