Fixes / Python 3 compatibility

RedisJSON / redisjson-py

An extension to redis-py for using Redis' ReJSON module

https://redisjson.io

BSD 2-Clause "Simplified" License

160 stars 34 forks source link

Fixes / Python 3 compatibility #5

Closed hootnot closed 7 years ago

hootnot commented 7 years ago

Fix:

import of unittest module (test won't run without this import)

client.py / test.py

python 3 compatibility by using six

changes to test.py to:

simplify the tests by using setUp method in testcase
PEP8 / flake8 corrections

Tests run both 2.7 and 3.5

Gendoc seems pretty incompatible with Python 3.x

itamarhaber commented 7 years ago

Thanks for this PR @hootnot, and my apologies for the delay in my response.

I'd really like v3 support - I know next to nothing about the nuances and your help is much appreciated. However.

Trying to run the test with Python 3 and your PR results in complaints about iteritems (removed in v3, naturally). Would you be kind enough to fix the PR so the test works?

itamarhaber commented 7 years ago

I've added Travis CI so we can test this too.

hootnot commented 7 years ago

Nice! will take a look at it ... see #6, discard this one