search

RedisLabs / memtier_benchmark

NoSQL Redis and Memcache traffic generation and benchmarking tool.
GNU General Public License v2.0
893 stars 216 forks source link

`--rate-limiting` flag not yet published to official Docker image #269

Open DrEsteban opened 4 hours ago

DrEsteban commented 4 hours ago

At the time of writing (9/24/2024), the --rate-limiting flag introduced by PR #237 has not yet been built and released to the official memtier Docker image redislabs/memtier_benchmark:latest, even though it was merged 10 months ago on 11/16/2023.

Is there an update on when it will be available? Is it expected for there to be such a delay in keeping the Docker image up to date with latest repo changes?

YaacovHazan commented 2 hours ago

@filipecosta90 ?

filipecosta90 commented 2 hours ago

@DrEsteban and @YaacovHazan the latest docker version is redislabs/memtier_benchmark:2.1.1 and both the 2.1.0 and 2.1.1 versions have this feature. 

docker run redislabs/memtier_benchmark:2.1.0 memtier_benchmark --help | grep rate
Unable to find image 'redislabs/memtier_benchmark:2.1.0' locally
2.1.0: Pulling from redislabs/memtier_benchmark
a8b1c5f80c2d: Pull complete 
14fb250f4a24: Pull complete 
a6c9d8d36585: Pull complete 
Digest: sha256:64f0abd43db50e75c1bd44a1b6a214e3b77efd37cbc16d8cabdc8c67d419acbe
Status: Downloaded newer image for redislabs/memtier_benchmark:2.1.0
      --rate-limiting=NUMBER     The max number of requests to make per second from an individual connection (default is unlimited rate).
                                 If you use --rate-limiting and a very large rate is entered which cannot be met, memtier will do as many requests as possible per second.
                                 To use a generated key or object, enter:
                                   __key__: Use key generated from Key Options.
                                   __data__: Use data generated from Object Options.
      --generate-keys            Generate keys for imported objects

Not sure why latest is not pointing towards it. Will check and reply back. In the meantime please use redislabs/memtier_benchmark:2.1.1