RedisLabs / redis-cluster-proxy

A proxy for Redis clusters.
GNU Affero General Public License v3.0
990 stars 129 forks source link

Install a crash handler (SEGFAULT) #25

Closed bsergean closed 4 years ago

bsergean commented 4 years ago

I'm getting a couple of restarts, and they don't seem to be related to high memory usage. Having a crash handler that display something on the console if a crash happen could help. I believe that redis has that.

redis-proxy-30-29wf5          1/1     Running       1          17m
redis-proxy-30-65zgp          1/1     Running       6          17m
redis-proxy-30-klq7z          1/1     Running       7          17m
redis-proxy-30-l42n6          1/1     Running       6          17m
redis-proxy-30-pfj8h          1/1     Running       5          17m
redis-proxy-30-q2bgk          1/1     Running       6          17m
artix75 commented 4 years ago

@bsergean Yeah, I'll add a crash handler in the next days

bsergean commented 4 years ago

Great. I think it will help with diagnosing weird production bugs.

On Jan 28, 2020, at 10:59 AM, artix notifications@github.com wrote:

@bsergean https://github.com/bsergean Yeah, I'll add a crash handler in the next days

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/artix75/redis-cluster-proxy/issues/25?email_source=notifications&email_token=AC2O6UNMN35YUDFUWTW4FLLRAB57ZA5CNFSM4KMMSBI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKEPSTY#issuecomment-579402063, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2O6UM2GW3TXVOUYNMKBZLRAB57ZANCNFSM4KMMSBIQ.

artix75 commented 4 years ago

@bsergean Done, crash handler implemented in the latest commit 😄

bsergean commented 4 years ago

Very cool. Let me try to use that !

I'm still using the connection_pool branch rebased from unstable (no conflicts found).

On Jan 28, 2020, at 11:54 AM, artix notifications@github.com wrote:

@bsergean https://github.com/bsergean Done, crash handler implemented in the latest commit 😄

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/artix75/redis-cluster-proxy/issues/25?email_source=notifications&email_token=AC2O6UNT5I7PWUU72K5U6O3RACERFA5CNFSM4KMMSBI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKEVPBY#issuecomment-579426183, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2O6UPQXE6CCDKE55U3NATRACERFANCNFSM4KMMSBIQ.

bsergean commented 4 years ago

Argh I couldn't merge that change in the connection_pool branch ... I'm getting conflicts ...

artix75 commented 4 years ago

@bsergean Yep, delete your local branch and fetch it again from scratch.

bsergean commented 4 years ago

Thanks that worked ; I started over and re-ran git rebase unstable in the connection_pool branch. I just deployed a new container which has the crash handler.

On Jan 28, 2020, at 1:51 PM, artix notifications@github.com wrote:

@bsergean https://github.com/bsergean Yep, delete your local branch and fetch it again from scratch.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/artix75/redis-cluster-proxy/issues/25?email_source=notifications&email_token=AC2O6UIEQ3BFFSETRQMI4RDRACSHBA5CNFSM4KMMSBI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKFBHOA#issuecomment-579474360, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2O6ULL3X6CKS6IJX6U3FLRACSHBANCNFSM4KMMSBIQ.