Proxy does not detect failover if old master dies quickly

JanBerktold commented 4 years ago

I managed to get the proxy to fail consistently with this repro case:

Send a CLUSTER FAILOVER command to a slave
Kill the old master that we fell away from after a successful failover
Proxy will continue to hammer the address of the old master because it did not get a MOVED response (which would cause a reconfiguration). This state goes on forever.

I haven't tested the "master fails w/o a successful failover before" case but it seems likely that that'd cause the same behaviour.

A possible solution here might be to trigger a reconfiguration whenever we loose a connection to a master?

artix75 commented 4 years ago

I will implement a "mandatory" reconfiguration after N failed reconnections.

amanullah92 commented 4 years ago

Hi @artix75 - just wanted to ask when you plan to fix this?

RedisLabs / redis-cluster-proxy