search

RedisLabs / redis-cluster-proxy

A proxy for Redis clusters.
GNU Affero General Public License v3.0
993 stars 132 forks source link

XADD/XREAD problem unstable branch versus 1.0 branch #37

Closed bsergean closed 4 years ago

bsergean commented 4 years ago

I have a test that fails in the current unstable branch. I XADD first, and the XREAD, but nothing comes in. This seem to work just fine in the 1.0 branch.

artix75 commented 4 years ago

@bsergean The 1.0 branch (actually the current "beta") does not currently include the "connections pool" feature that helped you solve the problem with XADD/XREAD. You can keep using the connections_pool branch for now.

The connections_pool features will be included in the next beta (beta2) of the 1.0 version. I'm currently integrating those features in order to include them in the unstable branch that will become the next "1.0-beta2" version.

I'll keep you updated about this development.

bsergean commented 4 years ago

Great thank you. Looking forward to testing it whenever it's ready.

On Feb 28, 2020, at 7:37 AM, artix notifications@github.com wrote:

@bsergean https://github.com/bsergean The 1.0 branch (actually the current "beta") does not currently include the "connections pool" feature that helped you solve the problem with XADD/XREAD. You can keep using the connections_pool branch at this moment.

The connections_pool features will be included in the next beta (beta2) of the 1.0 version. I'm currently integrating those features in order to include them in the unstable branch that will become the next "1.0-beta2" version.

I'll keep you updated about this development.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/artix75/redis-cluster-proxy/issues/37?email_source=notifications&email_token=AC2O6ULIAN6O4APOA7GF26DRFEVUPA5CNFSM4K5G6KP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENI5Z2Q#issuecomment-592567530, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC2O6UMF7NXTSVTASA4PVO3RFEVUPANCNFSM4K5G6KPQ.

bsergean commented 4 years ago

(sorry I keep forgetting about this problem and the connection pool solving it)

bsergean commented 4 years ago

I noticed that the unstable branch got the connection pool code, I've built that and it's running pretty well again now. It's only been running for 30m or so, but so far so good, while before it used to die much faster.

Thanks for all the hard work, connection pool seems to work very well !

artix75 commented 4 years ago

Yes, it has been moved to unstable and it will be part of the beta2. There's also a new feature related to connection pool: every time a client with a private connection gets disconnected, its own connections are recycled are re-added to the thread's connection pool if needed (if the pool is not already full).