search

RedisLabsModules / countminsketch

An apporximate frequency counter Redis module
http://redisbloom.io
GNU Affero General Public License v3.0
46 stars 9 forks source link

Performance benchmarks #7

Open jrots opened 7 years ago

jrots commented 7 years ago

Hi, just wondering if there is a big decrease in performance when there are a lot of items stored under one key? CMS.INCRBY key item1 1. CMS.INCRBY key item2 1 etc, for example adding 200M+ different items .. would querying be less performant afterwards & what would be the size concerns?

lfzCarlosC commented 6 years ago

Yeah, worth to be noted. Is there a command to measure the performance for CMS, like redis-benckmark?

lfzCarlosC commented 6 years ago

My testing shows that the average time for incrby operation is 27ms, not sure if this exceeds benchmark.

itamarhaber commented 6 years ago

Hello @jrots and @lfzCarlosC

AFAIR (sorry, it's been a while since I implemented this) CMS' operations are O(1), or constant time, regardless the number of items counted so far.

That said: a) This module is almost 3 years old and got no real attention (from us) - I'm positive it can be optimized. b) 27ms sounds a lot - what did you use to measure the performance with?