Closed neomantra closed 7 years ago
Ugh, no mac here - will need to check how to do this. @dvirsky - we had a mac issue at RedisConf, do you remember what it was?
As for -Og
, that's my bad - should actually be -O3
in this repo - changing, thanks @neomantra.
Those changes work for me on OSX -- I didn't try them on Linux, but LDFLAGS should be effective there too.
On 5/25/16 7:14 PM, Itamar Haber wrote:
Ugh, no mac here - will need to check how to do this. @dvirsky https://github.com/dvirsky - we had a mac issue at RedisConf, do you remember what it was?
As for |-Og|, that's my bad - should actually be |-O3| in this repo - changing, thanks @neomantra https://github.com/neomantra.
— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/RedisLabsModules/redex/issues/6#issuecomment-221735409
I can confirm that the changes work on Linux.
@dvirsky makes sense to do the same in all modules & the SDK, no?
@neomantra please verify that this can be closed with https://github.com/RedisLabsModules/redex/commit/f2d35edf438f1ac2279c312056589ddf83af6efc
Similarly, sorry I missed this many moons ago. Just built on OSX 10.12 this with the latest master without issue.
Building on OSX / clang fails with:
For the first two errors, linker options are getting passed to the compiler and it doesn't like that. I fixed by separating it into CFLAGS and LDFLAGS.
For the second error, clang doesn't support
-Og
.-O1
seems really close (there's some chatter about that on a clang bug to get parity with this gcc-feature). But really, why not build this library with-O2
?Here's a patch. I can make it a pull request if you want.
[EDIT: formatting]