RedisLabsModules / redisml

Machine Learning Model Server
http://redisml.io
Other
305 stars 44 forks source link

Make Random Forests work with depth > 8 #11

Open tkrynski opened 6 years ago

tkrynski commented 6 years ago

Currently there is a bug that causes a crash when random forest trees have a depth greater than 8. This is due to storing the path in a char.

This code fixes the situation by using multiple chars to serialize, which is aligned with the method used to deserialize. A test has also been added to demonstrate serialization working correctly with trees of depth up to 18.