search

RedisTimeSeries / prometheus-redistimeseries-adapter

Prometheus remote storage adapter for RedisTimeSeries
https://redistimeseries.io
BSD 3-Clause "New" or "Revised" License
33 stars 11 forks source link

Change labels retrieve logic to be compatible with RedisTimeSeries 1.2 #47

Closed alex6058 closed 4 years ago

alex6058 commented 4 years ago

In RedisTimeSeries 1.2 TS.MRANGE not show labels by default anymore and requires optional parameter WITHLABELS. Because of that, the labels retrieve mechanism in the Prometheus adapter stopped to work. For example, Prometheus command label_values(temperature{}, sensor) translated to rts command TS.MRANGE XXX YYY FILTER __name__=temperature which does not return labels anymore. I suggest to add WITHLABELS parameters and probably COUNT 1 to increase general efficiency. Or maybe use another internal logic to retrieve the list of labels.

alex6058 commented 4 years ago

Sorry, I just realized a fresh fix for that. So, the issue can be closed