search

RedlineResearch / elephant-tracks

0 stars 1 forks source link

Comparison between signed and unsigned in HashGraph.cpp #3

Closed greatmazinger closed 8 years ago

greatmazinger commented 8 years ago

HashGraph.cpp: In member function ‘jlong HashGraph::updateEdge(jlong, int, jlong)’: HashGraph.cpp:20:35: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] if (slot >= staticsEdges.size()) { ^ cc1plus: all warnings being treated as errors

greatmazinger commented 8 years ago

HashGraph.cpp: In member function ‘jlong HashGraph::updateEdge(jlong, unsigned int, jlong)’: │asm-all-3.3.jar HashGraph.cpp:54:23: error: comparison of unsigned expression < 0 is always false [-Werror=typ│.-(/data/rveroy/src/JAR)-------------------------------------------------------(rveroy@dell25)- e-limits] │`--> ls -l /data/rveroy/src/JAR/asm-3.3.jar } else if (slot < 0) { │ls: cannot access /data/rveroy/src/JAR/asm-3.3.jar: No such file or directory ^ │.-(/data/rveroy/src/JAR)-------------------------------------------------------(rveroy@dell25)- cc1plus: all warnings being treated as errors

greatmazinger commented 8 years ago

Fixed in commit 28815a88c1a87e8baba688990b3ed3a92d6bfd6f. And I also started reformatting to the sane indentations of 4. Because I like my eyes and indentations of 2 just gives me headaches. ;)

greatmazinger commented 8 years ago

The previous comment was meant to close this.