feat: change config validation order

Redocly / redocly-cli

⚒️ Redocly CLI makes OpenAPI easy. Lint/validate to any standard, generate beautiful docs, and more.

https://redocly.com/docs/cli/

MIT License

912 stars 139 forks source link

feat: change config validation order #1520

Closed DmitryAnansky closed 3 months ago

DmitryAnansky commented 5 months ago

What/Why/How?

Changes to config validation flow, linting configuration with resolved config
Extended types mixed into other oas types

Changes in this PR also results in code changes for Project

Affected changes & tests => https://github.com/Redocly/redocly/pull/7855

Reference

Closes https://github.com/Redocly/redocly-cli/issues/1223

Testing

Screenshots (optional)

Check yourself

[x] Code changed? - Tested with redoc/reference-docs/workflows (internal)
[x] All new/updated code is covered with tests
[ ] New package installed? - Tested in different environments (browser/node)

Security

[x] Security impact of change has been considered
[x] Code follows company security practices and guidelines

changeset-bot[bot] commented 5 months ago

🦋 Changeset detected

Latest commit: cfd1b001127364fb327652b128e59032c671c68e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

| Name | Type | | --------------------- | ----- | | @redocly/openapi-core | Minor | | @redocly/cli | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 5 months ago

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`redocly lint packages/core/src/benchmark/benches/rebilly.yaml`	997.3 ± 32.1	974.5	1073.9	1.00 ± 0.04
`redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml`	996.8 ± 16.3	975.6	1025.7	1.00

github-actions[bot] commented 5 months ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟡	Statements	77.26%	4505/5831
🟡	Branches	67.78%	2495/3681
🟡	Functions	70.98%	751/1058
🟡	Lines	77.46%	4241/5475

Show files with reduced coverage 🔻

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :----------------------------------------------------------------------------------------------------------------------------------------------------: | :--------------------------------------------------------- | :--------- | :------------------------------------------------------------ | :-------- | :------------------------------------------------------------ | | 🟢 |

`...` / load.ts

| 88.33% |

81.03% (+1.4% 🔼)

| 100% |

89.29% (-1.1% 🔻)

| | 🟢 | core/src/lint.ts | 95.65% | 83.33% | 100% | 95.56% |

Test suite run success

748 tests passing in 105 suites.

Report generated by 🧪jest coverage report action from cfd1b001127364fb327652b128e59032c671c68e