chore: add checks for browser env

Redocly / redocly-cli

⚒️ Redocly CLI makes OpenAPI easy. Lint/validate to any standard, generate beautiful docs, and more.

https://redocly.com/docs/cli/

MIT License

849 stars 129 forks source link

chore: add checks for browser env #1565

Closed tatomyr closed 1 month ago

tatomyr commented 1 month ago

What/Why/How?

Added checks for browser environment when using Node.js features in openapi-core.
Removed needless try...catch block.

Reference

Testing

Screenshots (optional)

Check yourself

[x] Code changed? - Tested with redoc/reference-docs/workflows (internal)
[ ] All new/updated code is covered with tests
[ ] New package installed? - Tested in different environments (browser/node)

Security

[x] Security impact of change has been considered
[x] Code follows company security practices and guidelines

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 55ba1eb7c2c3ed28aa7cd7e9cd38707a999478db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 1 month ago

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`redocly lint packages/core/src/benchmark/benches/rebilly.yaml`	952.0 ± 15.9	925.1	985.3	1.00
`redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml`	970.3 ± 26.2	932.3	1012.1	1.02 ± 0.03

github-actions[bot] commented 1 month ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟡	Statements	77.25%	4481/5801
🟡	Branches	67.48%	2467/3656
🟡	Functions	70.86%	744/1050
🟡	Lines	77.45%	4214/5441

Show files with reduced coverage 🔻

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :----------------------------------------------------------------------------------------------------------------------------------------------------: | :--------------------------------------------------------- | :------------------------------------------------------------- | :------- | :-------- | :------------------------------------------------------------ | | 🟢 |

`...` / load.ts

89.29% (+1.57% 🔼)

| 79.63% | 100% |

90.38% (+1.5% 🔼)

Test suite run success

735 tests passing in 102 suites.

Report generated by 🧪jest coverage report action from 55ba1eb7c2c3ed28aa7cd7e9cd38707a999478db