Redocly / swagger-repo

CLI tool to help you manage your OpenAPI(fka Swagger) repo.
MIT License
18 stars 29 forks source link

Update Swagger deps #9

Closed erikthered closed 5 years ago

erikthered commented 6 years ago

Swagger Editor to 3.5.2, Swagger UI to 3.13.4. This should allow generator-openapi-repo to support OpenAPI 3.0.x.

erikthered commented 6 years ago

Just an FYI: it seems that the 3.x branch of Swagger Editor has dropped the ability to autosave to a file on the local FS.

erikthered commented 6 years ago

I guess this project is abandoned now 🤷‍♂️

RomanHotsiy commented 6 years ago

@erikthered it is not abandoned. Sorry for not replying. We're just busy with other things right now 😞.

This project will be updated to support OpenAPI 3.0. Unfortunately, only updating dependencies is not enough for proper OpenAPI support. There are tons of places where the OpenAPI 2.0 paths are hardcoded (e.g. https://github.com/Rebilly/swagger-repo/blob/master/lib/index.js#L114)

erikthered commented 6 years ago

Sorry for the passive-aggressive comment, I could have been more constructive. I'd be happy to help out with updating it to OpenAPI 3.0, I didn't even think to look for hardcoded paths. If you have a chance to create an issue with some of the details I can try to make the required changes.

RomanHotsiy commented 6 years ago

@erikthered no worries 🙌!

I will create an issue on the weekend and will mention you there! Thanks for helping out!

RomanHotsiy commented 5 years ago

I am working on the big update to generator-openapi-repo which should be published early next week which will have a few breaking changes.

As a part of this effort, I did a major update to this repo with dependencies already updated (started working on it a few days ago).

I published swagger-repo@2.0.0-rc.0 which I think should be backward compatible with the old repo structure but may require a few changes (I think you will have to rename all occurrences of swagger.json, swagger.yaml to openapi.json and openapi.yaml). I would recommend waiting for the new generator though.