search

Redot-Engine / redot-engine

Redot Engine – Multi-platform 2D and 3D game engine
https://redotengine.org/
MIT License
4.78k stars 214 forks source link

[Godot] SDFGI broken with Intel Arc GPUs #156

Open MikeLundahl opened 1 month ago

MikeLundahl commented 1 month ago

Tested versions

4.3 stable

System information

Windows 11

Issue description

Turning on global illumination blows out every material with some roughness.

I've already created an issue ticket on it on the original repo: https://github.com/godotengine/godot/issues/90277. There's long thread with images, videos .etc describing the issue.

Steps to reproduce

Please see original issue

Minimal reproduction project (MRP)

MRP project can be downloaded in the original issue:

mrjustaguy commented 1 month ago

SDFGI is being replaced in Godot by HDDAGI, and isn't getting any attention. Due to the complexity of SDFGI it requires Experienced Rendering Developers to maintain, so it's unlikely to be fixed in Redot, and will most likely follow Godot in adopting HDDAGI once it comes out.

MikeLundahl commented 1 month ago

Yeah.. this seems to work better in HDDAGI (as I've tested). But that effort seems to move forward very slowly and seems to be worked on when Juan feels like it. So there's no knowing if HDDAGI will be implemented anytime soon even though it's been promoted.

One can hope for a Rendering expert with experience to join the team.

mrjustaguy commented 1 month ago

Basically HDDAGI got left behind in the last feature freeze, and more pressing matters got prioritized for the next release aimed at improving VFX, Lightmaps, and Performance optimizations, as well as further exposing Rendering to the User

RichardMiller90 commented 1 month ago

Yeah.. this seems to work better in HDDAGI (as I've tested). But that effort seems to move forward very slowly and seems to be worked on when Juan feels like it. So there's no knowing if HDDAGI will be implemented anytime soon even though it's been promoted.

One can hope for a Rendering expert with experience to join the team.

HDDAGI is taking time due to the goal of it reaching at lumen level render. It not yet there, it still need alot of time to clear or correct all error present in sdfgi. So don't say it when Juan feels like doing it. You could follow the progress on the pull request on their github. They have reached 3 main target out of 5. It mostly latency and ray directions issues that present. If the redot team want to implement their own they could look at what flax engine has implemented.

MikeLundahl commented 1 month ago

HDDAGI is taking time due to the goal of it reaching at lumen level render. It not yet there, it still need alot of time to clear or correct all error present in sdfgi. So don't say it when Juan feels like doing it. You could follow the progress on the pull request on their github. They have reached 3 main target out of 5. It mostly latency and ray directions issues that present. If the redot team want to implement their own they could look at what flax engine has implemented.

I am actually following the progress quite closely on what's happening on GitHub (since I'm very interested in having this fixed for the GPU I'm currently using and would prefer to be supported for the commercial project I'm working on). My comment wasn't meant to be offensive, but more an observation that he has a lot on his table, and I'm not sure this is a priority to him, and I haven't seen any progress on this for a long time (doesn't necessarily mean it's not being worked on. But there is no way for an outsider to know if progress is not shown)

Either way. This ticket is not about HDDAGI, it's about fixing the issue with a specific GPU. And if HDDAGI fixes that, that's great. But again, I have no idea when that's going to happen. And I suspect HDDAGI (especially with the ambition you mention) is a much bigger project than fixing the GPU support.

jawbroken commented 1 month ago

why are you reporting real bugs here? the guy who made this fork can't code or fix them. report them to the real project

mrjustaguy commented 1 month ago

it is still being worked on, this is from a report that's like 2 and a half weeks old https://godotengine.org/article/rendering-priorities-september-2024/

You can see typically what rendering contributors are discussing in meetings every week on https://files.godot.foundation/s/kdJ9ekAZZnQsFeM

There if you scroll down to 23.7. you'll see they discussed long term plans (6 months -2 years) and HDDAGI is there

jawbroken commented 1 month ago

@mrjustaguy oh, you're getting confused. those are posts about the real project, which is actually developing a game engine. you're posting on a fake grievance fork made by (and for) various forms of idiot. maybe repost on the real project 🫶🏽