Redot-Engine / redot-engine

Redot Engine – Multi-platform 2D and 3D game engine
https://redotengine.org/
MIT License
4.37k stars 181 forks source link

Copyright Usage and Reference Hunting #270

Closed Starkium closed 3 days ago

Starkium commented 1 week ago

Tested versions

N/A

System information

N/A

Issue description

We're in the process of renaming portions of the Godot code base to Redot. We have to be very careful about not changing copyright. Some stuff has been done by hand while other stuff we've tried to iterate a bit faster over. There is potential for some hiccups.

We're pinning this topic here so that anyone can report any places that seem be incorrectly changed. You may also report here places that haven't been changed yet that need to be changed.

Steps to reproduce

N/A

Minimal reproduction project (MRP)

N/A

MrDraxs commented 1 week ago

README.md and logo_outline.svg needs to be changed ASAP image

SkogiB commented 1 week ago

When importing old version projects, the version warning dialogue lists the prior version as Redot 3.x/4.x instead of the fact that it was actually a Godot project. It's a minor issue compared to others, and will require some extra work to detect Godot vs Redot projects, but it may be important in the future when Redot is more different and users will need to be warned clearly that moving a project from Godot to Redot might have unique concerns by then.

image

decryptedchaos commented 1 week ago

When importing old version projects, the version warning dialogue lists the prior version as Redot 3.x/4.x instead of the fact that it was actually a Godot project.

There isn't really a way to differentiate between a Godot/Redot project at the present time, you get this message simply because your project was last edited in 4.0 version of the engine (branding notwithstanding)

Its always advisable to make a copy of your project when you are trying to convert it to a new version, as it will make changes to your project.

obiwor commented 1 week ago

the logo was changed in the Bioblaze branch "redot-merge" commit :

SkogiB commented 1 week ago

Issue Bug Report page needs to be rebranded

image

Starkium commented 1 week ago

README.md and logo_outline.svg needs to be changed ASAP image

We're planning to change it substantially instead of just rebrand. Perhaps an intermediate step is ok.

apofex commented 1 week ago

README.md and logo_outline.svg needs to be changed ASAP image

We're planning to change it substantially instead of just rebrand. Perhaps an intermediate step is ok.

164 Will it be good?

kabachuha commented 1 week ago

The most important thing for any fork is to update the LICENSE.md file and add the new copyright on top of the existing ones

https://github.com/Redot-Engine/redot-engine/blob/b52811b83478bd06c5bcf39a93bbf53dd03cc9bf/LICENSE.txt#L1-L4

This way the original project will not own the new changes, including all the branding changes and will have to include the reverse mention if they'll need to grab the forked code parts

tokengamedev commented 1 week ago

Version.py needs to be updated, specifically line 351 and line 1387. It is causing improper visual studio project.

There are other properties being set, it can be changed later

SkogiB commented 1 week ago

Version.py needs to be updated, specifically line 351 and line 1387. It is causing improper visual studio project.

There are other properties being set, it can be changed later

We have a PR aimed at master that can go in once we've decided on a better branch organization here, I took a look at it earlier while reviewing all the PRs stacked up on readme changes that are outdated now

https://github.com/Redot-Engine/redot-engine/pull/63

tokengamedev commented 1 week ago

methods version.py needs to be updated, specifically line 351 and line 1387. It is causing improper visual studio project.

will be fixed by the PR https://github.com/Redot-Engine/redot-engine/pull/664

Spartan322 commented 5 days ago

Is this still relevant?

RadenTheFolf commented 3 days ago

This issue is now a subset of #692 and #705. Please defer all comments on changes for rebranding and copyrights to the version of the engine they apply to.