Redot-Engine / redot-engine

Redot Engine – Multi-platform 2D and 3D game engine
https://redotengine.org/
MIT License
4.79k stars 214 forks source link

compatibility vulkan error #674

Open gnuchanos opened 1 month ago

gnuchanos commented 1 month ago

Tested versions

Redot Engine v4.4.dev.custom_build.4f67c65d2 (2024-10-11 03:36:55 UTC)

System information

arch linux - v4.4.dev.custom - compatibility

Issue description

ERROR: Condition "err != VK_SUCCESS" is true. Returning: ERR_CANT_CREATE at: _initialize_devices (drivers/vulkan/rendering_context_driver_vulkan.cpp:831) ERROR: Condition "err != OK" is true. Returning: err at: initialize (drivers/vulkan/rendering_context_driver_vulkan.cpp:936)

Steps to reproduce

i just open engine

Minimal reproduction project (MRP)

new-game-project.zip

MisterPuma80 commented 1 month ago

I have this issue on Linux too. It is because they forked from a random commit in Godot master that is broken. They need to pull from Godot master again or rebase on a stable branch like 4.3

SkogiB commented 1 month ago

I have this issue on Linux too. It is because they forked from a random commit in Godot master that is broken. They need to pull from Godot master again or rebase on a stable branch like 4.3

GODOOOOOOT shakes fist at sky

SkogiB commented 1 month ago

I have this issue on Linux too. It is because they forked from a random commit in Godot master that is broken. They need to pull from Godot master again or rebase on a stable branch like 4.3

Do you know which file or commit it is? We'd rather just fix it if we can.

JohnnyThunder2 commented 1 month ago

Only pull request I recall that touched any part of the Vulkan API was this one... Can't really say if it's related or not, I'm inclined to dig deeper and see if I'm missing something... but might be worth trying to revert this change and see what happens: https://github.com/godotengine/godot/commit/b52811b83478bd06c5bcf39a93bbf53dd03cc9bf

https://github.com/godotengine/godot/commit/a2c29bdf789cac71e001092777e4a28016d77b1f

SkogiB commented 1 month ago

Only pull request I recall that touched any part of the Vulkan API was this one... Can't really say if it's related or not, I'm inclined to dig deeper and see if I'm missing something... but might be worth trying to revert this change and see what happens: godotengine@b52811b

godotengine@a2c29bd

We'll get a look at this soon yeah.

Spartan322 commented 1 month ago

Godot's current master branch has been merged to our master, so I believe this should be closed but I'd like that confirmed.

MisterPuma80 commented 1 month ago

Just tried master. Looks like it is still broken here and Godot upstream master branch on Ubuntu Linux 24.04.1 X86_64:

WARNING: GENERAL - Message Id Number: 0 | Message Id Name: Loader Message                                                                                                                 
    terminator_CreateInstance: Received return code -3 from call to vkCreateInstance in ICD /usr/lib/x86_64-linux-gnu/libvulkan_virtio.so. Skipping this driver.
    Objects - 1
        Object[0] - VK_OBJECT_TYPE_INSTANCE, Handle 93825210853776
     at: _debug_messenger_callback (drivers/vulkan/rendering_context_driver_vulkan.cpp:641)

Tested with this repo:

git clone https://github.com/godotengine/godot-demo-projects

Run this project (or any signifigant 3d project) and it just hangs or crashes:

godot-demo-projects/3d/truck_town/
Spartan322 commented 1 month ago

So does this have a corresponding Godot issue?

mattepm commented 4 weeks ago

Try out the just released 4.3 beta version. I opened a similar issue here, and with that version it seems solved: Redot UI freezes completely

SkogiB commented 3 weeks ago

Try out the just released 4.3 beta version. I opened a similar issue here, and with that version it seems solved: Redot UI freezes completely

Thanks for the leg work. I'm guessing this one is caused by upstream changes breaking things on 4.4dev. If our 4.3 betas are looking good, then we'll be good to go and we just need to let Godot do their thing upstream for 4.4 so we can then pull it down to our 4.4

Spartan322 commented 3 weeks ago

Pretty sure that one isn't, 4.4 alpha 1 just lacks any production optimizations because we never released a production build for it.

SkogiB commented 3 weeks ago

Pretty sure it isn't, 4.4 alpha 1 just lacks any production optimizations because we never released a production build for it.

Ahhh gotcha