search

Redpill-Linpro / alfresco-listmanager

Component used to manage custom list of values used in metadata forms.
13 stars 6 forks source link

Fix for issue#12,13&18 #19

Closed udaikumar26 closed 6 years ago

udaikumar26 commented 6 years ago

Changes are in the following files,

treelist-manager.js treelist-manager.get.properties customselectmany.ftl service-context.xml

billerby commented 6 years ago

Thanks for the pull request. However its impossible for me to see what changes you have done since the files in the two commits are not changed but totally replaced. Its impossible to compare them. Also there is not a describing commit message. This is a nice description of how to write a good commit message:

A good commit message looks like this:

Header line: explaining the commit in one line

Body of commit message is a few lines of text, explaining things
in more detail, possibly giving some background about the issue
being fixed, etc etc.

The body of the commit message can be several paragraphs, and
please do proper word-wrap and keep columns shorter than about
74 characters or so. That way "git log" will show things
nicely even when it's indented.

where that header line really should be meaningful, and really should be just one line. That header line is what is shown by tools like gitk and shortlog, and should summarize the change in one readable line of text, independently of the longer explanation.

udaikumar26 commented 6 years ago

Hi, I was not able to push only my changes from either eclipse or git bash that's when I tried with the upload option in GitHub. That's why you were seeing as everything replaced.

I get unauthorized error when trying to push through git bash. Do you know what I need to fix it?

On Mar 23, 2018 4:53 AM, "Erik Billerby" notifications@github.com wrote:

Thanks for the pull request. However its impossible for me to see what changes you have done since the files in the two commits are not changed but totally replaced. Its impossible to compare them. Also there is not a describing commit message. This is a nice description of how to write a good commit message:

A good commit message looks like this:

Header line: explaining the commit in one line

Body of commit message is a few lines of text, explaining things in more detail, possibly giving some background about the issue being fixed, etc etc.

The body of the commit message can be several paragraphs, and please do proper word-wrap and keep columns shorter than about 74 characters or so. That way "git log" will show things nicely even when it's indented.

where that header line really should be meaningful, and really should be just one line. That header line is what is shown by tools like gitk and shortlog, and should summarize the change in one readable line of text, independently of the longer explanation.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Redpill-Linpro/alfresco-listmanager/pull/19#issuecomment-375599340, or mute the thread https://github.com/notifications/unsubscribe-auth/AjAvrYAfAI89OFFF9MNAxMsNqNkf5zieks5thMYZgaJpZM4S3pMs .