search

RedpointArchive / phabricator

A Docker image that runs Phabricator, an open source software engineering tool
https://hub.docker.com/r/redpointgames/phabricator/
307 stars 98 forks source link

Improvements: Fix php-fpm path, update base image on build, include APC #2

Closed mattsta closed 9 years ago

mattsta commented 9 years ago

Three fixes! The APC install took way too long to figure out, but it's finally working (the problem was APC can only be enabled through the php-fpm.conf, not php.ini. If it's enabled in php.ini, nothing works!).

    Improve nginx.conf

    Workers can be higher and Phabricator complains if we have invalid
    paths in the config.

=======

    Update base image on build

    This is so we don't need to fetch new packages every time
    we `run` this Docker container.

    We just need to update base packages in this container at build
    time so we don't re-update every run.

=======

    Add APC support

    opensuse is stuck on PHP 5.4, so we can't use the PHP 5.5 built
    in opcode cache.  Until we use PHP 5.5 (or base all of this on
    a different system), we can use APC directly here.

    At this point, the entire image generates a _clean_ phabricator
    install with no "unresolved setup issues" except for the base
    case of "enable people to create accounts."
hach-que commented 9 years ago

Looks good to me.

The image will still perform security updates on boot though, regardless of the "RUN zypper --non-interactive patch" commands.

mattsta commented 9 years ago

Thanks!

The image will still perform security updates on boot though

Yeah, that's always good as a default. Letting the image pull its own updates on build is just a bonus so we can cheat without having to re-build a custom parent image too. :)