RedpointArchive / phabricator

A Docker image that runs Phabricator, an open source software engineering tool
https://hub.docker.com/r/redpointgames/phabricator/
307 stars 98 forks source link

stable branch without ENABLE_UPDATE_ON_START #69

Closed cguentherTUChemnitz closed 7 years ago

cguentherTUChemnitz commented 7 years ago

Hi there,

i would propose to create docker images of phabricator which are based on the stable branch of phabricator. The github phabricator code provides such a stable branch. So please create also stable tagged images based on this branch. This would be a better choice for production use of your container. https://github.com/phacility/phabricator/tree/stable

best, Christian

hach-que commented 7 years ago

You can actually already do this by overriding the branches for the repositories with environment variables, as outlined here: https://github.com/RedpointGames/phabricator/blob/master/ADVANCED-CONFIG.md#using-different-source-repositories

Note that you don't need to pass the URIs if you want to use the default repositories. You can just set the OVERRIDE_*_BRANCH environment variables to set them to origin/stable.

cguentherTUChemnitz commented 7 years ago

How do i use the stable branch without updating during startup? I want to run a phabricator version which is not changed during container restart, for backup purposes. When i want to upgrade the container version i rebuild the image. But setting the

OVERRIDE_PHABRICATOR_BRANCH=stable
OVERRIDE_ARCANIST_BRANCH=stable
OVERRIDE_LIBPHUTIL_BRANCH=stable

variables enables automatically the update on startup. So how do i get a stable branch phabricator build only during docker image build and not updating during restart? Therefore i changed the ticket title, to better describe the ENABLE_UPDATE_ON_START dependency.

hach-que commented 7 years ago

Are you using the image baking mechanism? If so, it shouldn't be running git pull again, as that is done in 10-boot-conf and that has:

if [ -f /baked ]; then
  exit 0
fi

at the top; which means once the image is baked it won't run it again.